Re: [TSVN] Installer defaults to "program files"

Peter Mounce wrote:

> I believe the [ProgramFilesFolder] variable will contain the localized
> path - but here, we're talking about the name of the folder by itself,
> in the LongName attribute. I don't have a clue how to do string
> manipulation in WiX; even if it's possible beyond concatenation.

Ok, I managed to fix this in revision 4163 by adding a CustomAction
entry which sets the INSTALLDIR property to
[ProgramFilesFolder]\[ProductName] if it isn't already set.

But what still puzzles me is this structure in StructureFragment.wxs:

<Directory Id="TARGETDIR" Name="SourceDir">
  <Directory Id="D__ProgramFilesFolder" Name="PFiles" LongName="Program
Files">
    <Directory Id="INSTALLDIR" Name="TSVN" LongName="TortoiseSVN">

Why the first two folders? IMHO they can be removed completely? At
least, I couldn't see any change in the installer when I removed those
and built the installer again.

Another thing:
install TSVN, don't reboot.
doublclick on the msi again, choose 'remove'

Uninstalling works, but the setup throws an error message.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org