[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Starting RepoBrowser using TortoiseProc and svn: link

From: Kirk Lapray <kirk.lapray_at_gmail.com>
Date: 2005-08-15 20:58:02 CEST

Here is a patch for TortoiseProc.cpp that checks for a "svn:" at the
beginning of a path for the repobrowser command and if found it then
looks for a "://" after "svn:" and if it finds one it then drops the
"svn:" from the beginning of the path. This allows other protocols
(like "http://" and "https://") to be used when clicking on a web link
that will open the RepoBrowser.

Kirk

On 8/10/05, Kirk Lapray <kirk.lapray@gmail.com> wrote:
> I agree, the first solution is not a good idea.
>
> Would it work to simply look for a "://" after "svn:"? If a "://" was
> found after any "svn:" then "svn:" could just be removed. Can you
> think of any reason a "://" would be in the string if it wasn't for
> protocol?
>
> Kirk
>
> On 8/10/05, SteveKing <steveking@gmx.ch> wrote:
> > Kirk Lapray wrote:
> >
> > > I could make a patch and send it in, but I am not sure how you would
> > > like this handled. I can think of a couple ways to implement this.
> > > It could be rewritten to work like the checkout command. That is if
> > > the path starts with "svn:" it would be removed and everything after
> > > it would be passed to the RepoBrowser. Or, the command could be
> >
> > bad idea. In that case 'normal' svn links won't work anymore and would
> > therefore break backward compatibility.
> >
> > > written to use the "url" variable. So, the command would work the
> > > same as it does now, but if the "path" variable is not set, and the
> > > "url" variable is, then it would use the "url" variable and like the
> > > checkout command the "svn:" and the beginning of the URL would be
> > > removed and everything else would be passed to the RepoBrowser. It
> > > seems like the second option would be the better solution, since from
> > > what I can see the repobrowser command does not currently use the
> > > "url" variable, but I could be wrong on that. This would not change
> > > the way the command currently works, but it would add the ability to
> > > pass in a HTTP URL using the "url" variable set to
> > > "svn:http://www.test.com".
> >
> > I think the best thing to do would be to simply remove the 'svn:' part
> > *only* if it's followed by another URL part (e.g. http://, file:///,
> > svn://, https://, ...). If it's not followed by say < 8 chars and then
> > '//' it won't be removed.
> >
> > Stefan
> >
> > --
> > ___
> > oo // \\ "De Chelonian Mobile"
> > (_,\/ \_/ \ TortoiseSVN
> > \ \_/_\_/> The coolest Interface to (Sub)Version Control
> > /_/ \_\ http://tortoisesvn.tigris.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
> > For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
> >
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Mon Aug 15 20:58:20 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.