[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Locked overlay

From: SteveKing <stefankueng_at_gmail.com>
Date: 2005-04-14 08:16:23 CEST

2005/4/13, Simon Large <slarge@slarge.plus.com>:
> Mark Phippard wrote:
> > I would rather know about the ones that I have personally locked so
> > that I remember to release the lock if I do not need it.
> That is exactly the point I made a few days ago, and AFAICT that
> information _is_ available in the WC entry structure.

Yes, that information is available. But, we don't need an overlay for
that, because TSVN will show you the locked files in the commit dialog
too (and you always should remove locks you have on commit, that's why
the "keep locks" checkbox is unchecked by default).

> The implementation described in r3030 (now reverted) is that a file has
> a 'locked' overlay when it is in subversion and read-only. IMHO that way
> of doing it is going to lead to a heap of confusion, so don't ever
> re-merge that revision. What you are saying with that overlay is:
> "This file is locked. If you want to unlock it you need to get a
> lock".

Well, if we merge that revision back in, then it's definitely not
called 'locked overlay' but maybe 'readonly overlay'.

> What Mark and I are describing is the condition where I _do_ hold a
> lock, and I want to be reminded to release it after making a commit.
> That information is cheap to obtain, and easy to display in an overlay.
> The condition for showing that overlay is:
> (status == insubversion) && (I_hold_the_lock)
> If the status is (almost) anything else, then I am working on the file
> and will not want to release it yet. For that one, the padlock icon does
> make sense because it corresponds with what SVN calls a lock.
> But I agree with Mark that we should maybe wait to see what other users
> actually want before we add another overlay.

I still think it's more important to inform the user that a file is
readonly and can't (shouldn't for some editors) be edited. That's like
saying: hey, that file is protected. To use it first lock it! I don't
really need an overlay telling me that I hold a lock on a file.
Seriously: the few files you lock can be easily remembered (if you
lock more files than you can remember, then you won't be working long
on a team because all others will kick you out soon - they need to
work on those files too).


  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Apr 14 08:16:42 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.