[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Locked overlay

From: Simon Large <slarge_at_slarge.plus.com>
Date: 2005-04-13 22:32:36 CEST

Mark Phippard wrote:
> I would rather know about the ones that I have personally locked so
> that I remember to release the lock if I do not need it.

That is exactly the point I made a few days ago, and AFAICT that
information _is_ available in the WC entry structure.

The implementation described in r3030 (now reverted) is that a file has
a 'locked' overlay when it is in subversion and read-only. IMHO that way
of doing it is going to lead to a heap of confusion, so don't ever
re-merge that revision. What you are saying with that overlay is:

  "This file is locked. If you want to unlock it you need to get a

Does that statement make any sense to you? In Subversion terms, when you
get a lock you are locking everyone _else_ out and making your _own_
copy editable. If you want to put an overlay on a file which is
read-only and in subversion then it needs to be called (and look like)
something else other than 'locked'. What it means is "This file is
read-only (probably) because it has svn:needs-lock and you don't have a
lock yet. You need to get a lock to edit it". Maybe that icon should be
a 'no entry' road sign.

What Mark and I are describing is the condition where I _do_ hold a
lock, and I want to be reminded to release it after making a commit.
That information is cheap to obtain, and easy to display in an overlay.
The condition for showing that overlay is:

    (status == insubversion) && (I_hold_the_lock)

If the status is (almost) anything else, then I am working on the file
and will not want to release it yet. For that one, the padlock icon does
make sense because it corresponds with what SVN calls a lock.

But I agree with Mark that we should maybe wait to see what other users
actually want before we add another overlay.


  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Apr 13 22:31:41 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.