Re: [TSVN] Tiny Bug in progress Dialog

At 19:15 05/01/2005 +0100, you wrote:

>Done in revision 2332.

I have a fairly violent objection to this bit (and not to the typo!), which
has just appeared in CSVNProgressDlg

         else
         //The only element exceedint the data array is the warning about
         //critical events during the update/commit/...

I don't like the fact that we infer 'red' from 'not stored in the list in
the same way as everything else'.

What about I add a 'colour' (or 'color') element to the data array? I'd
set the colour in CSVNProgressDlg::Notify at the point we create the array
elements, then just read the colour in the custom draw function.

That way all the logic about conflicted, etc, could be contained in the
Notify routine, and not spread around. (I might also add a 'bConflicted'
flag to the data, too.)

It seems to me that having some things in the list which are not in the
data array causes potential for confusion, especially when you consider
sorting the list. (We already have the situation where sorting the list
messes it up by sorting-in some of the 'extra' items and losing others
altogether.)

What do you think of this idea?

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Jan 5 20:04:30 2005