[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Tiny Bug in progress Dialog

From: SteveKing <steveking_at_gmx.ch>
Date: 2005-01-05 20:07:37 CET

Will Dean wrote:
> At 19:15 05/01/2005 +0100, you wrote:
>
>> Done in revision 2332.
>
>
> I have a fairly violent objection to this bit (and not to the typo!),
> which has just appeared in CSVNProgressDlg
>
> else
> //The only element exceedint the data array is the warning about
> //critical events during the update/commit/...
>
> I don't like the fact that we infer 'red' from 'not stored in the list
> in the same way as everything else'.

I don't like that either. But I couldn't think of anything else right now.

> What about I add a 'colour' (or 'color') element to the data array? I'd
> set the colour in CSVNProgressDlg::Notify at the point we create the
> array elements, then just read the colour in the custom draw function.

That's a good idea (why couldn't I think of that???).
Are you already working on that? I'm currently working on something else...

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Jan 5 20:09:09 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.