Re: [TSVN] Question on code

Will Dean wrote:

> I'm currently running Lint on the TSVN code, which is amusing, and will
> generate a vast, bitty, patch.
>
> One of the things it's noticed from HistoryCombo.cpp is this:
>
> hwndEdit = (HWND)::SendMessage(this->m_hWnd, CBEM_GETEDITCONTROL, 0, 0);
> if (NULL == hwndEdit)
> {
> //if not, try the old standby
> if(hwndEdit==NULL)
> {
> CWnd* pWnd = this->GetDlgItem(1001);
>
> Clearly these two 'Ifs' are checking the same thing...
>
> Was there some more profound intention here, or should we just get rid
> of the inner one?

I don't think so. The history combo was rewritten once, but not by me. I
guess that's a leftover from that time ;)
Just remove it - if _you_ can't see a reason to keep it, then I surely
don't either.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org