[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[TSVN] Question on code

From: Will Dean <svn_at_indcomp.co.uk>
Date: 2004-12-16 13:58:41 CET


I'm currently running Lint on the TSVN code, which is amusing, and will
generate a vast, bitty, patch.

One of the things it's noticed from HistoryCombo.cpp is this:

hwndEdit = (HWND)::SendMessage(this->m_hWnd, CBEM_GETEDITCONTROL, 0, 0);
if (NULL == hwndEdit)
         //if not, try the old standby
          CWnd* pWnd = this->GetDlgItem(1001);

Clearly these two 'Ifs' are checking the same thing...

Was there some more profound intention here, or should we just get rid of
the inner one?



To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Dec 16 13:59:47 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.