[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Commit Dialog Behaviour

From: Nathan Creek <nathan_at_adweb.com.au>
Date: 2004-11-11 06:59:03 CET

Nathan Kidd wrote:
> If the main commit dialog didn't close when clicking "Commit", but
> rather had the "progress commit" dialog as a child, and only closed if
> the commit was successful it would be a big improvement.
> <snip>
> Thoughts?

I see your point, and it would be nice if there was some way to do this
reliably.

A problem i see happening is that a commit dialog in the background
could end up with an out-of-date file list.
If the commit dialog stays in the background and the Commit fails due to
needing to update. Then you do an update on the trunk and one of the
files that got updated causes build errors and you modify previously
unmodified files to fix it. Now the Commit dialog in the background
won't have the files you've just changed listed, you'd have to close it
and open it again to make it rescan.

I'd suggest an alternative would be to save a list of the files that are
selected when the dialog is cancelled, and then the next time Commit is
brought up have a button or something to load the previous selections.
Or maybe a better option would be to save the files that aren't selected
and have a button restore previously unselected files. This way if there
are new files in the list they will be selected by default. I don't know
if that is desirable, but considering all modified files are selected by
default to begin with it's probably consistent behaviour.

That's my 2c anyway.

Nathan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Nov 11 06:59:18 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.