[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Accelerator Keys

From: Mark Phippard <markp_at_softlanding.com>
Date: 2005-11-05 14:08:01 CET

Denny,

First, thanks for working on this. There have obviously been a number of
people that have expressed an interest in the feature so it is good to have
someone working on it.

The way you have approached this sounds correct to me. I would expect the
existing actions to be used if possible, so adding an interface to them
sounds like the right approach. I also do not see any problems with
posting a binary version for people to play with. That is entirely up tp
you.

My recommendation would be to focus on the three actions you have
implemented. Get your patch as cleaned up as possible. I know you have
been working on this for a long time, so spend a while looking carefully at
the patch itself and make sure it is as clean as possible (doesn't contain
any discarded experiments) etc.. Make sure you have localized any new
strings you have added etc...

When you have it ready, add a PATCH issue to our issue tracker and then
attach the patch. Try to add some kind of explanation of what you did, so
we know how to evaluate the patch and what to write in the eventual commit
message.

Once we get this patch committed into the code base, then you can look into
adding support for additional actions at your own discretion.

Thanks

Mark

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
Received on Sun Nov 6 00:08:01 2005

This is an archived mail posted to the Subclipse Dev mailing list.