[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Accelerator Keys

From: Denny Valliant <valliant_at_unm.edu>
Date: 2005-11-05 05:14:43 CET

Yello!

    I have a question regarding the addtion of accel-key-bindable
actions for subclipse.

I've gotten them to work the way CVS keys work (no fancy detection of
context/site,
just plain old "if there's resources selected, do X with 'em") but I
never asked if it was
ok to modify the action classes to implement
IWorkbenchWindowActionDelegate and
add init() methods to them.

I've been running with the source modified in said manner (plus two null
checks) for
a while now and haven't gotten anything weird, but that don't mean I
know my
onions, so I figured I'd put it out there and see what the folk with
experience and
knowledge of said source had to think.

If it's ok, then I'll go ahead and hit up every action. So far I've done
commit, update
and synchronize (don't know if the built in "team" one works or not).
Added a null
check to Synchronize (gets the active page from the plugin if
getTarget() is null) and
one in TeamActions (selection!=null && !selection.isEmpty()) added to
the function
"getSelectedAdaptables()". Bet that's all Id run into for the rest, but
who knows. I
have enough for my self and the interest has been modest so I won't
bother if no
one wants/needs them at this point. As always, newest patch is available
with
compiled plugins at www.unm.edu/~valliant/subclipse/.

If having them pre-compiled there is some type of issue I can nix 'em
and save
5 mb of storage. I don't think it is, but I didn't ask or check, so... I
put it out here...

That is all, carry on.
:Denny
Received on Sat Nov 5 15:14:43 2005

This is an archived mail posted to the Subclipse Dev mailing list.