[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

issues reported by FindBugs on svnClientAdapter

From: Eugene Kuleshov <eu_at_md.pp.ru>
Date: 2005-08-21 22:19:48 CEST

  Here is the issues FindBugs found in svnClientAdapter

Major:

OS:
org.tigris.subversion.svnclientadapter.javahl.AbstractJhlClientAdapter.propertySet(java.io.File,String,java.io.File,boolean)
may fail to close stream AbstractJhlClientAdapter.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/javahl
line 1104

  Minor issues:

Class exposes synchronization and semaphores in its public interface.
This class uses synchronization along with wait(), notify() or
notifyAll() on itself (the this reference). Client classes that use
this class, may, in addition, use an instance of this class as a
synchronizing object. Because two classes are using the same object for
synchronization, Multithread correctness is suspect. You should not
synchronize nor call semaphore methods on a public reference. Consider
using a internal private member variable to control synchronization.
-----
PS: Class
org.tigris.subversion.svnclientadapter.commandline.CmdLineByteStreamPumper
exposes synchronization and semaphores in its public interface.
CmdLineByteStreamPumper.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/commandline
line 68
PS: Class
org.tigris.subversion.svnclientadapter.commandline.CmdLineStreamPumper
exposes synchronization and semaphores in its public interface.
CmdLineStreamPumper.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/commandline
line 79

CD: Class org.tigris.subversion.svnclientadapter.javahl.JhlDirEntry has
a circular dependency with other classes. JhlDirEntry.java
 svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/javahl

CD: Class org.tigris.subversion.svnclientadapter.javahl.JhlLogMessage
has a circular dependency with other classes. JhlLogMessage.java
 svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/javahl

CD: Class org.tigris.subversion.svnclientadapter.javahl.JhlStatus has a
circular dependency with other classes. JhlStatus.java
 svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/javahl

DLS: Dead store to local variable in method
org.tigris.subversion.svnclientadapter.basictests.DeleteTest.testRemoveUrls()
 DeleteTest.java
 svnClientAdapter/src/testcases/org/tigris/subversion/svnclientadapter/basictests
 line 299

DLS: Dead store to local variable in method
org.tigris.subversion.svnclientadapter.SVNUrlTest.testCaseInsensitiveHttpProtocols()
 SVNUrlTest.java
 svnClientAdapter/src/testcases/org/tigris/subversion/svnclientadapter
 line 43

DLS: Dead store to local variable in method
org.tigris.subversion.svnclientadapter.SVNUrlTest.testCaseInsensitiveHttpProtocols()
 SVNUrlTest.java
 svnClientAdapter/src/testcases/org/tigris/subversion/svnclientadapter
 line 44

DLS: Dead store to local variable in method
org.tigris.subversion.svnclientadapter.SVNUrlTest.testNullURLThrowsInvalidURLException()
 SVNUrlTest.java
 svnClientAdapter/src/testcases/org/tigris/subversion/svnclientadapter
 line 20

Dm: Method
org.tigris.subversion.svnclientadapter.javahl.AbstractJhlClientAdapter.annotate(String,org.tigris.subversion.svnclientadapter.SVNRevision,org.tigris.subversion.svnclientadapter.SVNRevision)
invokes toString() method on a String; just use the String
 AbstractJhlClientAdapter.java
 svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/javahl
 line 130

Dm: Method
org.tigris.subversion.svnclientadapter.javahl.AbstractJhlClientAdapter.commit(java.io.File[],String,boolean,boolean)
invokes toString() method on a String; just use the String
 AbstractJhlClientAdapter.java
 svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/javahl
 line 259

Dm: Method
org.tigris.subversion.svnclientadapter.javahl.AbstractJhlClientAdapter.lock(java.io.File[],String,boolean)
invokes toString() method on a String; just use the String
 AbstractJhlClientAdapter.java
 svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/javahl
 line 1578

Dm: Method
org.tigris.subversion.svnclientadapter.javahl.AbstractJhlClientAdapter.unlock(java.io.File[],boolean)
invokes toString() method on a String; just use the String
 AbstractJhlClientAdapter.java
 svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/javahl
 line 1616

MS:
org.tigris.subversion.svnclientadapter.commandline.CmdLineClientAdapterFactory.COMMANDLINE_CLIENT
isn't final but should be CmdLineClientAdapterFactory.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/commandline
MS:
org.tigris.subversion.svnclientadapter.commandline.CmdLineNotifyAction.actionNames
should be moved out of an interface and made package protected
CmdLineNotifyAction.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/commandline
MS:
org.tigris.subversion.svnclientadapter.commandline.CmdLineNotifyStatus.statusNames
should be moved out of an interface and made package protected
CmdLineNotifyStatus.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/commandline
MS:
org.tigris.subversion.svnclientadapter.javahl.JavaSvnClientAdapterFactory.JAVASVN_CLIENT
isn't final but should be JavaSvnClientAdapterFactory.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/javahl
MS:
org.tigris.subversion.svnclientadapter.javahl.JhlClientAdapterFactory.JAVAHL_CLIENT
isn't final but should be JhlClientAdapterFactory.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/javahl
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.ADDED isn't
final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.CONFLICTED
isn't final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.DELETED isn't
final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.EXTERNAL isn't
final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.IGNORED isn't
final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.INCOMPLETE
isn't final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.LOCKED isn't
final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.MERGED isn't
final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.MISSING isn't
final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.MODIFIED isn't
final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.NONE isn't
final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.NORMAL isn't
final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.OBSTRUCTED
isn't final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.REPLACED isn't
final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNStatusKind.UNVERSIONED
isn't final but should be SVNStatusKind.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter
MS: org.tigris.subversion.svnclientadapter.SVNUrl.SEGMENT_SEPARATOR
isn't final but should be SVNUrl.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter

UrF: Unread field:
org.tigris.subversion.svnclientadapter.basictests.ExpectedWC$Item.isSwitched
 ExpectedWC.java
 svnClientAdapter/src/testcases/org/tigris/subversion/svnclientadapter/basictests
 line 438
UrF: Unread field:
org.tigris.subversion.svnclientadapter.commandline.SvnOutputParserTest$Notification.action
 SvnOutputParserTest.java
 svnClientAdapter/src/testcases/org/tigris/subversion/svnclientadapter/commandline
 line 15
UrF: Unread field:
org.tigris.subversion.svnclientadapter.commandline.SvnOutputParserTest$Notification.kind
 SvnOutputParserTest.java
 svnClientAdapter/src/testcases/org/tigris/subversion/svnclientadapter/commandline
 line 15
UrF: Unread field:
org.tigris.subversion.svnclientadapter.commandline.SvnOutputParserTest$Notification.mimeType
 SvnOutputParserTest.java
 svnClientAdapter/src/testcases/org/tigris/subversion/svnclientadapter/commandline
 line 15
UrF: Unread field:
org.tigris.subversion.svnclientadapter.javahl.JhlAnnotations$Annotation.changed
 JhlAnnotations.java
 svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/javahl
 line 35
Received on Mon Aug 22 06:19:48 2005

This is an archived mail posted to the Subclipse Dev mailing list.