[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

issues reported by FindBugs on org.tigris.subversion.subclipse.ui

From: Eugene Kuleshov <eu_at_md.pp.ru>
Date: 2005-08-21 22:08:57 CEST

  Here is the issues FindBugs found in org.tigris.subversion.subclipse.ui

  Major:

NP: Possible null pointer dereference in
org.tigris.subversion.subclipse.ui.SVNUIPlugin.openError(org.eclipse.swt.widgets.Shell,String,String,Throwable,int)
SVNUIPlugin.java
org.tigris.subversion.subclipse.ui/src/org/tigris/subversion/subclipse/ui
line 284

OS:
org.tigris.subversion.subclipse.ui.wizards.generatediff.GenerateDiffFileOperation.run(org.eclipse.core.runtime.IProgressMonitor)
may fail to close stream GenerateDiffFileOperation.java
org.tigris.subversion.subclipse.ui/src/org/tigris/subversion/subclipse/ui/wizards/generatediff
line 80

  Minor:

CD: Class org.tigris.subversion.subclipse.ui.comments.CommentsManager
has a circular dependency with other classes.
CD: Class org.tigris.subversion.subclipse.ui.history.HistoryView has a
circular dependency with other classes.
CD: Class
org.tigris.subversion.subclipse.ui.pending.PendingOperationsView has a
circular dependency with other classes.
CD: Class
org.tigris.subversion.subclipse.ui.repository.RepositoryManager has a
circular dependency with other classes.
CD: Class org.tigris.subversion.subclipse.ui.SVNUIPlugin has a circular
dependency with other classes.
CD: Class org.tigris.subversion.subclipse.ui.SVNUIPlugin has a circular
dependency with other classes.
CD: Class
org.tigris.subversion.subclipse.ui.wizards.sharing.DirectorySelectionPage
has a circular dependency with other classes.

Dm:
org.tigris.subversion.subclipse.ui.properties.SVNPropertyPage.addSecondSection(org.eclipse.swt.widgets.Composite)
invokes dubious Boolean constructor; use Boolean.valueOf(...) instead
 SVNPropertyPage.java
 org.tigris.subversion.subclipse.ui/src/org/tigris/subversion/subclipse/ui/properties
 line 186

SS: Unread field:
org.tigris.subversion.subclipse.ui.dialogs.IgnoreResourcesDialog.ACTION_KEY;
should this field be static?

UrF: Unread field:
org.tigris.subversion.subclipse.ui.authentication.QuestionDialog.realm
QuestionDialog.java
UrF: Unread field:
org.tigris.subversion.subclipse.ui.authentication.QuestionDialog.showAnswer
QuestionDialog.java
UrF: Unread field:
org.tigris.subversion.subclipse.ui.dialogs.CommitDialog.unaddedResources
CommitDialog.java
UrF: Unread field:
org.tigris.subversion.subclipse.ui.operations.CommitOperation.selectedResources
CommitOperation.java
UrF: Unread field:
org.tigris.subversion.subclipse.ui.SVNUIPlugin.markerListener
SVNUIPlugin.java

UuF: Unused field:
org.tigris.subversion.subclipse.ui.annotations.AnnotateView.previousTextSelection
AnnotateView.java
UuF: Unused field:
org.tigris.subversion.subclipse.ui.properties.SVNPropertyPage.pathValue
SVNPropertyPage.java

UwF: Unwritten field:
org.tigris.subversion.subclipse.ui.annotations.AnnotateView.previousListSelection
AnnotateView.java
UwF: Unwritten field:
org.tigris.subversion.subclipse.ui.compare.SVNLocalCompareInput.shell
SVNLocalCompareInput.java
UwF: Unwritten field:
org.tigris.subversion.subclipse.ui.repository.model.SVNModelElement.runnableContext

UwF: Unwritten field:
org.tigris.subversion.subclipse.ui.SynchronizeWizard.importWizard
SynchronizeWizard.java

WMI: Method
org.tigris.subversion.subclipse.ui.internal.XMLWriter.printTag(String,java.util.HashMap,boolean,boolean)
makes inefficient use of keySet iterator instead of entrySet iterator
XMLWriter.java
org.tigris.subversion.subclipse.ui/src/org/tigris/subversion/subclipse/ui/internal
line 65

WMI: Method
org.tigris.subversion.subclipse.ui.operations.CommitOperation.execute(org.eclipse.core.runtime.IProgressMonitor)
makes inefficient use of keySet iterator instead of entrySet iterator
CommitOperation.java
org.tigris.subversion.subclipse.ui/src/org/tigris/subversion/subclipse/ui/operations
line 49

WMI: Method
org.tigris.subversion.subclipse.ui.subscriber.SVNSynchronizeOperation.run(org.eclipse.core.runtime.IProgressMonitor)
makes inefficient use of keySet iterator instead of entrySet iterator
SVNSynchronizeOperation.java
org.tigris.subversion.subclipse.ui/src/org/tigris/subversion/subclipse/ui/subscriber
line 59
Received on Mon Aug 22 06:08:57 2005

This is an archived mail posted to the Subclipse Dev mailing list.