Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

On 2019-10-11 06:45, Daniel Shahaf wrote:
...
> From autogen.sh to 'make check', all steps pass with PYTHON=/usr/bin/python3.

There were two failures in 1.11 on tests.
  
https://lists.apache.org/thread.html/366e77c7443a0c575b47de150a2c394e1e685fde8887c805a656a33d@%3Cusers.subversion.apache.org%3E

and it seems they still exist in trunk.

on FreeBSD 11.1, Python 3.7.0, Subversion trunk_at_1868235:
[[[
W: CWD: /home/futatuki/work/subversion/vwc/trunk/subversion/tests/cmdline
Traceback (most recent call last):
   File "/home/futatuki/work/subversion/vwc/trunk/subversion/tests/cmdline/svntest/main.py", line 1931, in run
     rc = self.pred.run(sandbox)
   File "/home/futatuki/work/subversion/vwc/trunk/subversion/tests/cmdline/svntest/testcase.py", line 178, in run
     result = self.func(sandbox)
   File "/home/futatuki/work/subversion/vwc/trunk/subversion/tests/cmdline/svnadmin_tests.py", line 3862, in dump_no_canonicalize_svndate
     assert propval + '\n' in dump_lines
AssertionError
FAIL: svnadmin_tests.py 69: svnadmin dump shouldn't canonicalize svn:date
]]]

[[[
W: A1/B/lambda has unexpectected contents
W: EXPECTED svn-test-work/working_copies/tree_conflict_tests-26/A1/B/lambda (match_all=True):
W: | This is the file 'lambda'.
W: | This is more content.
W: ACTUAL svn-test-work/working_copies/tree_conflict_tests-26/A1/B/lambda:
W: CWD: /home/futatuki/work/subversion/vwc/trunk/subversion/tests/cmdline
Traceback (most recent call last):
   File "/home/futatuki/work/subversion/vwc/trunk/subversion/tests/cmdline/svntest/main.py", line 1931, in run
     rc = self.pred.run(sandbox)
   File "/home/futatuki/work/subversion/vwc/trunk/subversion/tests/cmdline/svntest/testcase.py", line 178, in run
     result = self.func(sandbox)
   File "/home/futatuki/work/subversion/vwc/trunk/subversion/tests/cmdline/tree_conflict_tests.py", line 1547, in local_missing_dir_endless_loop
     [ "This is the file 'lambda'.\n", "This is more content.\n"], contents)
   File "/home/futatuki/work/subversion/vwc/trunk/subversion/tests/cmdline/svntest/verify.py", line 503, in compare_and_display_lines
     expected.display_differences(message, label, actual)
   File "/home/futatuki/work/subversion/vwc/trunk/subversion/tests/cmdline/svntest/verify.py", line 154, in display_differences
     display_lines(message, self.expected, actual, e_label, label)
   File "/home/futatuki/work/subversion/vwc/trunk/subversion/tests/cmdline/svntest/verify.py", line 478, in display_lines
     logger.warn('| ' + x.rstrip())
TypeError: can only concatenate str (not "bytes") to str
FAIL: tree_conflict_tests.py 26: endless loop when resolving local-missing dir
]]]

The former failure can be fixed by attached patch, fix_svnadmin_tests_patch.txt

The latter also can be fixed by fix_tree_conflict_tests_patch.txt
at least so that the test can be passed on Python 3. However, from above
stack trace, I think it is incomplete because there still exists some sort of
confusion between bytes and str in subversion/tests/cmdline/svntest/*.py

Cheers,

-- 
Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>