[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

From: Jun Omae <jun66j5_at_gmail.com>
Date: Mon, 21 Oct 2019 19:55:26 +0900


I'm trying to build and test swig-py3 branch (r1868677) on Ubuntu 16.04 with
Python 3.7, however I get FAILED(failures=16, errors=22) from the unit tests.

Investigating the issue with helps of Yasuhito, that is caused by using old
SWIG version with no SWIG_PYTHON_STRICT_BYTE_CHAR feature. The
SWIG_PYTHON_STRICT_BYTE_CHAR feature is available since SWIG 3.0.9 but SWIG is
3.0.8 in Ubuntu 16.04.

I consider that we should warn the required SWIG version at least.

[1] https://github.com/swig/swig/blob/rel-3.0.10/CHANGES#L160

Index: build/ac-macros/swig.m4
--- build/ac-macros/swig.m4 (revision 1868677)
+++ build/ac-macros/swig.m4 (working copy)
@@ -91,12 +91,12 @@
      # If you change the required swig version number, don't forget to update:
      # subversion/bindings/swig/INSTALL
- if test -n "$SWIG_VERSION" && test "$SWIG_VERSION" -ge "103024"; then
+ if test -n "$SWIG_VERSION" && test "$SWIG_VERSION" -ge "300009"; then
        AC_MSG_WARN([Detected SWIG version $SWIG_VERSION_RAW])
- AC_MSG_WARN([Subversion requires SWIG >= 1.3.24])
+ AC_MSG_WARN([Subversion requires SWIG >= 3.0.9])

Index: subversion/bindings/swig/INSTALL
--- subversion/bindings/swig/INSTALL (revision 1868677)
+++ subversion/bindings/swig/INSTALL (working copy)
@@ -65,7 +65,7 @@

  Step 1: Install a suitable version of SWIG (which is
- currently SWIG version 1.3.24 or later).
+ currently SWIG version 3.0.9 or later).

      * Perhaps your distribution packages a suitable version - if it does
        install it, and skip to the last bullet point in this section.
@@ -72,7 +72,7 @@

      * Go to http://www.swig.org/, download the source tarball, and unpack.

- * In the SWIG-1.3.xx directory, run ./configure.
+ * In the SWIG-3.0.xx directory, run ./configure.

          If you plan to build the Python bindings, and have a system
          with more than one version of Python installed, you may need
@@ -95,7 +95,7 @@
          Run 'make && make install'

      * To verify you have SWIG installed correctly, run "swig -version"
- from the command line. SWIG should report that it is version 1.3.24
+ from the command line. SWIG should report that it is version 3.0.9
        or newer.

  Step 1a: Install py3c library if building Python SWIG bindings.

Jun Omae <jun66j5_at_gmail.com> ($BBgA0(B $B=a(B)
Received on 2019-10-21 12:55:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.