Re: [PATCH] fix repos-to-wc copy dst parents creation

From: Nikita Slyusarev <nslus_at_yandex-team.com>
Date: Sun, 14 Oct 2018 22:39:48 +0300

14.10.2018, 17:17, "Branko Čibej" <brane@apache.org>:

Hey. Thanks for the nudge.

I have just one comment: The two new test scenarios you should be split
into their own test cases. Not only is it bad practice to make a test
case test more than one scenario, it also defeats parallel test execution.

Fixed version (the patch is also attached):

[[[

Correctly handle existing parent directories when performing repos-to-wc copy.

* subversion/libsvn_client/copy.c

(repos_to_wc_copy): If add_parents flag is set and destination parent

directory exists, but is unversioned, put it under version control. Wc-to-wc

copy behaves this way, and so should repos-to-wc copy do.

* subversion/tests/cmdline/copy_tests.py

(copy_make_parents_repo_wc_existing_unversioned_dst,

copy_make_parents_wc_wc_existing_unversioned_dst): Check behaviour with dst

directory pre-creation for both repo-to-wc and wc-to-wc test cases.

]]]

Nikita Slyusarev

Yandex

text/x-diff attachment: subversion-libsvn_client-copy-with_tests-1.patch

Received on 2018-10-14 21:40:06 CEST

This message: [ Message body ]
Next message: Branko Čibej: "Re: [PATCH] fix repos-to-wc copy dst parents creation"
Previous message: Nikita Slyusarev: "Re: [PATCH] fix repos-to-wc copy dst parents creation"
In reply to: Branko Čibej: "Re: [PATCH] fix repos-to-wc copy dst parents creation"
Next in thread: Branko Čibej: "Re: [PATCH] fix repos-to-wc copy dst parents creation"
Reply: Branko Čibej: "Re: [PATCH] fix repos-to-wc copy dst parents creation"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]