Re: [PATCH] fix repos-to-wc copy dst parents creation
On 14.10.2018 21:39, Nikita Slyusarev wrote:
> 14.10.2018, 17:17, "Branko Čibej" <brane_at_apache.org>:
> > Hey. Thanks for the nudge.
> > I have just one comment: The two new test scenarios you should be split
> > into their own test cases. Not only is it bad practice to make a test
> > case test more than one scenario, it also defeats parallel test execution.
> Fixed version (the patch is also attached):
> Correctly handle existing parent directories when performing repos-to-wc copy.
> * subversion/libsvn_client/copy.c
> (repos_to_wc_copy): If add_parents flag is set and destination parent
> directory exists, but is unversioned, put it under version control. Wc-to-wc
> copy behaves this way, and so should repos-to-wc copy do.
> * subversion/tests/cmdline/copy_tests.py
> copy_make_parents_wc_wc_existing_unversioned_dst): Check behaviour with dst
> directory pre-creation for both repo-to-wc and wc-to-wc test cases.
Received on 2018-10-15 10:57:28 CEST
This is an archived mail posted to the Subversion Dev