[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.10 tasks: update CHANGES and roll RC1 or beta1

From: Stefan Sperling <stsp_at_apache.org>
Date: Mon, 25 Dec 2017 14:20:07 +0100

On Mon, Dec 25, 2017 at 12:21:46PM +0100, Stefan Fuhrmann wrote:
> So, this is the result. It also covers the changes
> skipped by release.py (first block of 5 entries).
> I will try to reformulate & group the list and then
> commit them to CHANGES by Wednesday.

Thanks! This helps a lot with completing the changelog.

However, I have some mild concerns.

I don't think it makes sense to list changes such as:

>     * Add support for tracing moves backwards in history to the conflict
> resolver. (r1808263)

>     * Make svn --non-interactive use recommended tree conflict resolution
> (r1805620)

>     * fsfs: Don't store SHA1 for property representations in format 8.
> (r1816348)

Because these are not changes relative to 1.9, they are changes made
between 1.10-dev and another 1.10-dev.

Also, entries such as:

>     * Fix a slightly broken private API. (r1807966)

>     * Refactor the merging of merge rangelists (r1802470 et al)

>     * Merge the 'shelve' branch to trunk. (r1815228 et al)

>     * release.py: Don't discard errors. (r1804278)

provide little value to end users. They don't convey enough information
in isolation so it's unclear why they are important.

The changelog should not be a mirror of what the commit log says.
Rather, it should list the significant changes from 1.9.0 to 1.10.0,
excluding any changes which were already backported to 1.9/1.8.

I spent about a day and a half already on many 1.10 changelog entries,
and it would be nice to reduce this time with more automation.
But I found most of my time was spent cross-checking entries with the
commit log and STATUS files rather than building an initial list.

On the bright side, there are some entries the script found which are
relevant and which I missed. Some of these are probably new (my last
commit to CHANGES was r1783882). Here are some entries which I think
are important:

>    * Add a new --vacuum-pristines option to 'svn cleanup'. (r1802787

>    * Add '--include' and '--exclude' options to 'svnadmin dump'.

>     * svnadmin: Introduce the `--normalize-props` option for the load

I am not going to go through all of these now. I suppose you already
understand the point I'm trying to make.
We can still do a final review at the end and toss out entries which aren't
really needed, but please don't just add new entries without considering
and weighing each of them. Please carefully check each entry.
Received on 2017-12-25 14:20:23 CET

This is an archived mail posted to the Subversion Dev mailing list.