Re: SVN-4668 : svnadmin dump node header order has changed

On Mon, Jan 23, 2017 at 09:35:31AM -0800, Luke Perkins wrote:
> Team,
>
> Summary: I have attached a proposed set of changes to the following files:
>
> 1. Subversion/include/svn_repos.h
> 2. Subversion/libsvn_repos/dump.c
> 3. Subversion/svnadmin/svnadmin.c
>

Hi Luke,

Welcome to SVN development!

(I am bypassing the technical issue at hand for now, since I would like
us to focus on the patch submission process first. Once that is resolved,
we can discuss the actual problem more easily.)

For more details about our patch submission process, see here:
http://subversion.apache.org/docs/community-guide/general.html#patches

Can you please send the output of 'svn diff' to show your changes instead
of attaching whole files? This makes it easier to understand and review
your changes. You can either copy the output of 'svn diff' into your mail
reader (making sure that whitespace and formatting remains intact), or
attach a file created by redirecting the output of 'svn diff' to a file
like this:

  svn diff > /tmp/issue-4668.patch

Please also include a proposed log message with your patch.

Thank you,
Stefan
Received on 2017-01-23 19:34:23 CET