[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

SVN-4668 : svnadmin dump node header order has changed

From: Luke Perkins <lukeperkins_at_epicdgs.us>
Date: Mon, 23 Jan 2017 09:35:31 -0800

Team,

 

Summary: I have attached a proposed set of changes to the following files:

 

1. Subversion/include/svn_repos.h
2. Subversion/libsvn_repos/dump.c
3. Subversion/svnadmin/svnadmin.c

 

All of these changes are based upon trunk rev. 1779691 (Friday, January 20,
2017).

 

Details:

 

I am new to the code development of SVN, so I am asking for some advice
regarding the best way to proceed implementing a proposed fix for svnadmin
dump.

 

Since you were the author of the latest changes to libsvn_repos/dump.c
regarding the function, "write_revision_headers", I have attached a proposal
to be implemented on the svn trunk. See attached.

 

Questions for the team:

 

1. Would this be an acceptable approach to address future direction for
dump while still addressing legacy format?
2. How do we go about getting this checked into the trunk?
3. I have defined a new switch for "svnadmin dump -pre-1.8-dump" to
activate the old node key order. I did my best to try to keep the original
authors style. Is this an acceptable switch name?
4. A new parameter to the primary function, "svn_repos_dump_fs4",
called "svn_boolean_t pre_1_8_dump,". I have search the source code and I
think I have all of the function calls covered. Are there any other
considerations?
5. What is the verification procedure for implementing this change?

 

Let me know if there are any other considerations we need to implement the
proposed fix.

 

Thank-you,

 

Luke Perkins

2581 Flagstone Drive

San Jose, California 95132-2611

Cell: 719-339-0987

Home: 408-457-1857

 

  • text/plain attachment: dump.c
Received on 2017-01-23 18:37:46 CET

This is an archived mail posted to the Subversion Dev mailing list.