Re: SVN-4668 : svnadmin dump node header order has changed

Stefan Sperling wrote on Mon, Jan 23, 2017 at 19:33:52 +0100:
> On Mon, Jan 23, 2017 at 09:35:31AM -0800, Luke Perkins wrote:
> > Team,
> >
> > Summary: I have attached a proposed set of changes to the following files:
> >
> > 1. Subversion/include/svn_repos.h
> > 2. Subversion/libsvn_repos/dump.c
> > 3. Subversion/svnadmin/svnadmin.c
> >
>
> Hi Luke,
>
> Welcome to SVN development!
>

Feel free to join us on IRC (#svn-dev on freenode), too.

> Can you please send the output of 'svn diff' to show your changes instead
> of attaching whole files? This makes it easier to understand and review
> your changes. You can either copy the output of 'svn diff' into your mail
> reader (making sure that whitespace and formatting remains intact), or
> attach a file created by redirecting the output of 'svn diff' to a file
> like this:
>
> svn diff > /tmp/issue-4668.patch

If it's your first time sending patches, I suggest that you send them as
attachments. Most mailers corrupt "inline" patches by default, so
you'll have fewer round-trips if you just use an attachment up front.

Cheers,

Daniel
Received on 2017-01-23 20:27:42 CET