Re: [PATCH] improved behaviour of tools/backup/hot-backup.py

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 22 Oct 2015 12:12:16 +0100

Roberto Reale <roberto.reale82_at_gmail.com> writes:

> Do you think the patch can be improved in any regards?
>
> I would like to "breed it up", so to say, to an acceptable status.

Your patch assumes that all the files in the backup are still present in
the source repository and that is not always true. For example pack on
a FSFS repository could remove revision files, a commit to a BDB
repository could delete a log file. Any such files will cause archive
creation to fail with your patch.

-- 
Philip Martin
WANdisco

Received on 2015-10-22 13:12:32 CEST

This message: [ Message body ]
Next message: Roberto Reale: "Re: [PATCH] improved behaviour of tools/backup/hot-backup.py"
Previous message: Roberto Reale: "Re: [PATCH] improved behaviour of tools/backup/hot-backup.py"
In reply to: Roberto Reale: "Re: [PATCH] improved behaviour of tools/backup/hot-backup.py"
Next in thread: Roberto Reale: "Re: [PATCH] improved behaviour of tools/backup/hot-backup.py"
Reply: Roberto Reale: "Re: [PATCH] improved behaviour of tools/backup/hot-backup.py"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]