Re: [PATCH] improved behaviour of tools/backup/hot-backup.py

Which behaviour would you deem correct?

Just assigning a default permission set when the original file cannot
be found, or inferring it from the file type (e.g., revision files
should not be executable)?

Regards,
Roberto

On Thu, Oct 22, 2015 at 1:12 PM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> Roberto Reale <roberto.reale82_at_gmail.com> writes:
>
>> Do you think the patch can be improved in any regards?
>>
>> I would like to "breed it up", so to say, to an acceptable status.
>
> Your patch assumes that all the files in the backup are still present in
> the source repository and that is not always true. For example pack on
> a FSFS repository could remove revision files, a commit to a BDB
> repository could delete a log file. Any such files will cause archive
> creation to fail with your patch.
>
> --
> Philip Martin
> WANdisco
Received on 2015-10-22 16:21:21 CEST