Re: [PATCH] improved behaviour of tools/backup/hot-backup.py

Do you think the patch can be improved in any regards?

I would like to "breed it up", so to say, to an acceptable status.

Regards,
Roberto

On Fri, Oct 2, 2015 at 5:44 PM, Roberto Reale <roberto.reale82_at_gmail.com> wrote:
> Hi everybody,
>
> enclosed is a puny patch I wrote against the script
> tools/backup/hot-backup.py.in.
>
> When creating a backup archive of a live repository, the "legacy"
> behaviour of the script is simply to call tar.add() on a hotdump copy.
> This has, however, an inconvenience when the original repository is on
> a POSIX filesystem and the hotcopy dump is written e.g. on a CIFS
> filesystem, thus leading to a possible "permission leakage".
>
> My patch changes this behaviour by letting the script build up the
> archive file by file, and paying special care in copying the
> permissions for each file from the repository itself rather than from
> the hotcopy dump.
>
> Do you think it would be useful?
>
> Regards,
> Roberto
Received on 2015-10-22 11:55:05 CEST