Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

On Wed, Oct 21, 2015 at 2:21 PM, Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
wrote:

> Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:
>
> > Could you at least use the new API in svn_repos__compare_files instead
> > of re-implementing parts of the FS back-end but worse? I know this is
> > the code as it has been in 1.8 but that does not make the it any better.
>
> Speaking of /branches/1.9.x, I would like to nominate this change as is.
> It should be easier to review, because we would be restoring things to a
> known previous state, instead of mixing new with old.
>

Old is 1.9, new is whatever delta is being proposed
for backport. Combining both patches will effectively
reduce code churn.

Ultimately, the decision of what to nominate will be
yours of course.

> As for /trunk, I think that we could do that, so I sketched this option in
> the attached patch.

The patch looks o.k.

> Currently I am not sure that there are no subtle but
> important differences between two implementations, so doing this is going
> to require a bit more time. Hopefully, I would be able to sort it out
> after
> we're done with the backport.
>

You see, that's the whole point here. People must not
ave to rely on undocumented behaviour but (only) on
API guarantees. If the implementation does not fulfil
those guarantees, that's a bug.

-- Stefan^2.
Received on 2015-10-22 11:47:21 CEST