[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

From: Branko Čibej <brane_at_wandisco.com>
Date: Thu, 11 Jun 2015 18:30:11 +0200

On 11.06.2015 17:49, Branko Čibej wrote:
> On 11.06.2015 17:34, Evgeny Kotkov wrote:
>> Branko Čibej <brane_at_wandisco.com> writes:
>>
>>> If '--quiet' means 'suppress progress', then the result is exactly as
>>> expected. We could change 'svnadmin verify' to behave differently, e.g.,
>>> only display error notifications in --quiet mode; I agree that would be
>>> better than the current behaviour, but again, this has nothing to do
>>> with the API itself.
>> I don't think that the current behavior — entirely losing error information —
>> is expected. For example, here is what "svnadmin help verify" says about -q:
>>
>> -q [--quiet] : no progress (only errors to stderr)
> See my patch; a bit outdated (I've improved it a bit since then), but it
> fixes this issue.

Evgeny, please take a look at r1684940.

I don't really like the fact that with this change and 'svnadmin
--keep-going --quiet', the text "Error verifying revision N" gets
printed to stderr; but I couldn't think of a better way to join the
error to the revision it was emitted for. I'd love to find a better
solution.

-- Brane
Received on 2015-06-11 18:30:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.