[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

From: Branko Čibej <brane_at_wandisco.com>
Date: Thu, 11 Jun 2015 17:49:22 +0200

On 11.06.2015 17:34, Evgeny Kotkov wrote:
> Branko Čibej <brane_at_wandisco.com> writes:
>> If '--quiet' means 'suppress progress', then the result is exactly as
>> expected. We could change 'svnadmin verify' to behave differently, e.g.,
>> only display error notifications in --quiet mode; I agree that would be
>> better than the current behaviour, but again, this has nothing to do
>> with the API itself.
> I don't think that the current behavior — entirely losing error information —
> is expected. For example, here is what "svnadmin help verify" says about -q:
> -q [--quiet] : no progress (only errors to stderr)

See my patch; a bit outdated (I've improved it a bit since then), but it
fixes this issue.

>> I think we're at the point where we're trying to polish the UI. It is
>> rather late in the day for that. The minor tweak required in svnadmin to
>> emit errors in --quiet mode can be pushed into RC3, but I'd pretty much
>> stop there; we can always make minor UI changes later on. I wouldn't
>> change svn_repos_verify_fs3 any more; it's consistent and does what it
>> advertises.
> Fine, but I suspect that this fix probably isn't going to address the very last
> problem in the --keep-going code. It would be a pity to delay Subversion
> 1.9.0 because of that.

Let's not make the perfect the enemy of the good enough; we'd never have
released 1.0 otherwise. :)

-- Brane
Received on 2015-06-11 17:49:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.