[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1682265 - /subversion/trunk/subversion/libsvn_fs_fs/util.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Thu, 28 May 2015 18:54:43 +0300

On 28 May 2015 at 18:45, <stefan2_at_apache.org> wrote:
> Author: stefan2
> Date: Thu May 28 15:45:55 2015
> New Revision: 1682265
>
> URL: http://svn.apache.org/r1682265
> Log:
> Correctly fsync() after renames in FSFS on Win32. We must flush the disk
> buffers after the rename, otherwise the metadata may not be persistent.
> Moreover, if the rename is degraded to a copy by Win32, we won't even have
> the complete file contents on disk without a buffer flush.
>
Are you sure about this change? From my analysis that I posted two
years ago [1] metadata changes are persistent fine on Windows, the
only thing we need to make sure to flush data changes before move. Did
you able to reproduce data corruption on VM?

This change should significantly degrade performance of commit
operation, so it should be done only if we are really sure that this
code required.

[1] http://svn.haxx.se/dev/archive-2013-05/0245.shtml

-- 
Ivan Zhakov
Received on 2015-05-28 17:55:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.