Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

On 28 May 2015 at 16:43, Philip Martin <philip.martin_at_wandisco.com> wrote:
> Ivan Zhakov <ivan_at_visualsvn.com> writes:
>
>> I hope you're aware the original code has unbounded memory usage?
>
> No, could you explain? Is it a problem with the underlying stream code,
> or with the way it was used?
>
svn_stream_printf() allocates buffer for resulting string in pool
provided. The original code didn't have iterpool, so all lines written
to manifest file was allocated in scratch pool. The manifest file
usually is not big to cause problems, but it's still unbounded memory
usage.

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com