[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fsfs7 index offset validation

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 19 May 2015 02:16:41 +0000

Ivan Zhakov wrote on Mon, May 18, 2015 at 12:27:38 +0300:
> On 18 May 2015 at 02:16, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > subversion/libsvn_fs_fs/rev_file.c:263,
> > subversion/libsvn_fs_fs/low_level.c:212: (apr_err=SVN_ERR_INCORRECT_PARAMS)
> > svn: E200004: Invalid L2P offset in revision footer
> > subversion/libsvn_subr/string.c:986: (apr_err=SVN_ERR_INCORRECT_PARAMS)
> > svn: E200004: Number '888' is out of range '[0, 546]'
> >
> It would be nice to have revision number or filename as a part of error message.

Agreed. (I usually try to have an %s in every error message.) The
other errors in the same function need revnum info added to them too.

Cheers,

Daniel

P.S. There is already a 'rev' parameter to that function, which is
unused; I'm not sure why that didn't cause a compiler warning.
Received on 2015-05-19 04:21:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.