[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [Patch] Expression support for SVNPath and SVNParentPath

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 26 Feb 2015 21:02:14 +0100

> -----Original Message-----
> From: Philip Martin [mailto:philip.martin_at_wandisco.com]
> Sent: donderdag 26 februari 2015 20:13
> To: Bert Huijben
> Cc: Graham Leggett; 'Subversion Development'
> Subject: Re: [Patch] Expression support for SVNPath and SVNParentPath
>
> Bert Huijben <bert_at_qqmail.nl> writes:
>
> > The ‘}’ is matched by that at the end of the if lines in both
> > blocks. (Not really our common code style)
>
> The problem is that there is a '{' before the #if and a '}' inside the
> #if but no '}' in the #else. I think #if code compiles and the #else
> code fails.
>
> >> + if (arg2) {
> >> +#if AP_MODULE_MAGIC_AT_LEAST(20111025,3)
> >> + const char *expr_err = NULL;
> >> +
> >> + conf->fs_path->expr = ap_expr_parse_cmd(cmd, arg2,
> >> AP_EXPR_FLAG_STRING_RESULT,
> >> + &expr_err, NULL);
> >> + if (expr_err) {

Did you see the '{' ^^^ here?

> >> + apr_pstrcat(cmd->temp_pool,
> >> + "Cannot parse expression in SVNPath: ",
> >> + expr_err, NULL);
> >
> > expr_err contains the error message if parsing fails but it appears to
> > be discared.
> >
> >> + }

Which is closed here?

        Bert
Received on 2015-02-26 21:04:30 CET

This is an archived mail posted to the Subversion Dev mailing list.