Re: [Patch] Expression support for SVNPath and SVNParentPath

Bert Huijben <bert_at_qqmail.nl> writes:

> The ‘}’ is matched by that at the end of the if lines in both
> blocks. (Not really our common code style)

The problem is that there is a '{' before the #if and a '}' inside the
#if but no '}' in the #else. I think #if code compiles and the #else
code fails.

>> + if (arg2) {
>> +#if AP_MODULE_MAGIC_AT_LEAST(20111025,3)
>> + const char *expr_err = NULL;
>> +
>> + conf->fs_path->expr = ap_expr_parse_cmd(cmd, arg2,
>> AP_EXPR_FLAG_STRING_RESULT,
>> + &expr_err, NULL);
>> + if (expr_err) {
>> + apr_pstrcat(cmd->temp_pool,
>> + "Cannot parse expression in SVNPath: ",
>> + expr_err, NULL);
>
> expr_err contains the error message if parsing fails but it appears to
> be discared.
>
>> + }
>
> You have an unmatched } inside the #if but not in the #else, one of them
> is wrong.
>
>> +#else
>> + return "Expressions require httpd v2.4.0 or higher"
>> +#endif
>> + }
>> +

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*