[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Issue #4467 - blame youngest to oldest needs to handle SVN_INVALID_REVNUM - 1.9 blocker?

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 17 Feb 2015 16:26:54 +0000

This issue looks like one that we should fix for 1.9.

Several of the blame functions don't work properly when start=HEAD and end=N
because they compare start and end to work out whether start is less than or
greater than end.  At least these functions need attention:

  svn_client_blame5 gets younger_rev wrong
  svn_ra_get_file_revs2 gets the capability check wrong
  svn_ra_serf__get_file_revs gets the peg_rev wrong

See also r1568872 which fixed a similar problem with log.

Philip wrote on IRC just now,


$ svn blame -rHEAD:1000000 ../src/README
svn: E235000: In file '../src/subversion/libsvn_client/blame.c' line 497: assertion failed ((frb->last_filename == NULL) || frb->include_merged_revisions)

[...] I think it is a consequence of things like blame.c:659 which does younger_end.value.number = MAX(start_revnum, end_revnum);

Anyone want to take a look at it?

- Julian
Received on 2015-02-17 17:28:49 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.