[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] Fix multiple reporting of the same lock in FSFS.

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 09 Feb 2015 17:48:59 +0000

Sergey Raevskiy <sergey.raevskiy_at_visualsvn.com> writes:

> To reproduce this bug in test, I've emulated nested locks by creating a file
> ('/A'), locking it and then replacing by directory with same name. This looks
> like a 'directory lock', and I am trying to say that if this happens in real
> life, the FS API would behave incorrectly.

I added a few extra comments to the test and committed, thanks!

I suspect the implementation is now more complicated than necessary.
walk_locks and walk_locks_baton could be removed, walk_digest_files
could be renamed to indicate that only a single digest file is accessed.
The callers of walk_locks would call the renamed function directly.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-02-09 18:50:15 CET

This is an archived mail posted to the Subversion Dev mailing list.