[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1616600 - in /subversion/trunk/subversion: include/svn_error_codes.h libsvn_fs_x/pack.c libsvn_fs_x/reps.c libsvn_fs_x/reps.h tests/libsvn_fs_x/fs-x-pack-test.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Thu, 07 Aug 2014 23:49:14 +0200

On 07.08.2014 23:35, stefan2_at_apache.org wrote:
> Author: stefan2
> Date: Thu Aug 7 21:35:01 2014
> New Revision: 1616600
> URL: http://svn.apache.org/r1616600
> Log:
> Explicitly limit the dimensions of a star delta container which allows us
> to cast sizes to 32 bits.

Can we explicitly use 32-bit types then, pretty please? Peppering the
code with casts is not the way to silence compiler warnings. Using
correct types is.

That might require adding number pack/unpack functions that work with
correctly sized types, but since the idea is to detect overflow in the
numbers, this is actually a good idea (and does not affect the packed
representation of the numbers).

-- Brane

Branko Čibej | Director of Subversion
WANdisco | Realising the impossibilities of Big Data
e. brane_at_wandisco.com
Received on 2014-08-07 23:54:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.