Re: svn commit: r1616600 - in /subversion/trunk/subversion: include/svn_error_codes.h libsvn_fs_x/pack.c libsvn_fs_x/reps.c libsvn_fs_x/reps.h tests/libsvn_fs_x/fs-x-pack-test.c

On Thu, Aug 7, 2014 at 11:49 PM, Branko Čibej <brane_at_wandisco.com> wrote:

> On 07.08.2014 23:35, stefan2_at_apache.org wrote:
>
> Author: stefan2
> Date: Thu Aug 7 21:35:01 2014
> New Revision: 1616600
>
> URL: http://svn.apache.org/r1616600
> Log:
> Explicitly limit the dimensions of a star delta container which allows us
> to cast sizes to 32 bits.
>
>
> Can we explicitly use 32-bit types then, pretty please? Peppering the code
> with casts is not the way to silence compiler warnings. Using correct types
> is.
>

You mean like svn_stringbuf32_t?

All FSX internal data structures in use explicit bitness (or are
supposed to do so) to prevent unpleasant surprises when
downgrading from 64 to 32 bit server software.

However, at some point we have to cast from the platform
types we use in our aux data structures to the internal ones.

-- Stefan^2.
Received on 2014-08-08 00:10:48 CEST