[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

From: Branko Čibej <brane_at_wandisco.com>
Date: Thu, 07 Aug 2014 21:16:52 +0200

On 07.08.2014 19:03, Ben Reser wrote:
> This appears to be because pointers are unsigned and apr_size_t is signed.

You mean the other way around, surely.

> Guess we can just cast the pointer arithmetic to apr_size_t. So they end up
> looking like this respectively:
> if (*len > (apr_size_t)(end - *p))
> if (len != (apr_size_t)(end - p))

There's a reason why ptrdiff_t exists. Maybe we should use it? I'm not
fond of adding casts to code to silence warnings that could be fixed by
using the correct type throughout.

-- Brane

Branko Čibej | Director of Subversion
WANdisco | Realising the impossibilities of Big Data
e. brane_at_wandisco.com
Received on 2014-08-07 21:21:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.