Re: [VOTE] Merge svn-auth-x509 branch to trunk?

On 07.08.2014 19:03, Ben Reser wrote:
> This appears to be because pointers are unsigned and apr_size_t is signed.

You mean the other way around, surely.

> Guess we can just cast the pointer arithmetic to apr_size_t. So they end up
> looking like this respectively:
>
> if (*len > (apr_size_t)(end - *p))
> if (len != (apr_size_t)(end - p))

There's a reason why ptrdiff_t exists. Maybe we should use it? I'm not
fond of adding casts to code to silence warnings that could be fixed by
using the correct type throughout.

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco | Realising the impossibilities of Big Data
e. brane_at_wandisco.com