[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 26 Jun 2014 17:45:36 +0200

On Thu, Jun 26, 2014 at 05:08:38PM +0200, Stefan Fuhrmann wrote:
> I see three alternative ways to code that function
> 1. As hard coded string / byte sequence (current implementation).
> Cons:
> * Hard to write, hard to review by just looking at it (applies to time
> until initial release only).
> Pros:
> * Explicitly coded as constant, deterring people from changing it.
> * Independent of other code, i.e. unintended changes to the format /
> encoding generated by the normal code usually become apparent
> when running the test suite.
> 2. Use our txn code to write r0. This should be simple and might
> at most require some special ID handling.
> Cons:
> * Generating incompatible r0s is likely not caught by our test suite
> (assuming that reader and writer functions are in sync). Basically
> all the risk that comes with dynamically generating a "constant".
> * Test cases must make sure our backward compat repo creation
> options create repos that can actually be used by old releases.
> (we might want explicit test for that anyway, though)
> Pros:
> * No or very little special code for r0 (not sure, yet).
> * Format / encoding changes don't require new r0 templates.
> 3. Write code to "stitch" r0 together, e.g. string_add(md5("END\n")).
> Cons:
> * No more robust than 1. but requires much more code.
> * May _look_ easy to understand but an actual offline review is still hard.
> Pros:
> * Widely independent of other code, although not as much as 1.
> Do you generally agree with the range of options and their assessment?
> Which one would you pick and why?
> I'd be fine with switching to option 2 as long as everyone understands
> the implications.

How about we write option 3 code to generate option 1 code, then hardcode
the generated option 1 code but put the option 3 code in a comment near
the option 1 code as a reference?
Received on 2014-06-26 17:46:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.