[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][RFC] svnadmin load --ignore-dates

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 5 Feb 2014 10:45:41 +0000 (GMT)

C. Michael Pilato wrote:

> Mostly looking
> for general feedback on the idea of the "sounds useful if it works" or
> "you *really* don't want to go there" variety, but deeper review is of
> course welcome, too.

It seems a reasonable enhancement to me. Simple and to the point.

(A couple of style nits:

-  is_date = strcmp(name, SVN_PROP_REVISION_DATE) ? FALSE : TRUE;
+  is_date = strcmp(name, SVN_PROP_REVISION_DATE) == 0;

and you unnecessarily moved the block of code that stores the loaded date stamp into the baton.)

- Julian
Received on 2014-02-05 11:46:25 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.