Re: [PATCH][RFC] svnadmin load --ignore-dates

On 02/05/2014 05:45 AM, Julian Foad wrote:
> C. Michael Pilato wrote:
>
>> Mostly looking
>> for general feedback on the idea of the "sounds useful if it works" or
>> "you *really* don't want to go there" variety, but deeper review is of
>> course welcome, too.
>
> It seems a reasonable enhancement to me. Simple and to the point.
>
> (A couple of style nits:
>
> - is_date = strcmp(name, SVN_PROP_REVISION_DATE) ? FALSE : TRUE;
> + is_date = strcmp(name, SVN_PROP_REVISION_DATE) == 0;

Noted.

> and you unnecessarily moved the block of code that stores the loaded date stamp into the baton.)

Oops! Good catch.
Received on 2014-02-05 14:28:49 CET