[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][RFC] svnadmin load --ignore-dates

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Wed, 5 Feb 2014 06:07:53 +0100

On Wed, Feb 5, 2014 at 6:03 AM, Stefan Fuhrmann <
stefan.fuhrmann_at_wandisco.com> wrote:

> On Wed, Feb 5, 2014 at 4:02 AM, Branko ─îibej <brane_at_wandisco.com> wrote:
>
>> On 05.02.2014 03:10, Daniel Shahaf wrote:
>>
>> However, 'load --ignore-dates' has another use-case: preventing the "-r
>> {DATE} doesn't work as intended" syndrome when loading a project's history
>> into an existing repository.
>>
>>
>> I would argue that this is an implementation bug, pure and simple. The
>> fact that it has persisted since svn-1.0 doesn't change anything. There is
>> no reason why -r {DATE} couldn't be made to work regardless of the ordering
>> of the dates; it's just that no-one has taken the trouble to actually fix
>> the filesystem to return valid results in all cases.
>>
>
> That would be extremely expensive to do in the existing backends:
> We would need to effectively read all revision properties of all revs.
> If we added an index ("revision order by time stamp"), we could do
> better but would need to update the index upon every (rev) propset.
>

One more thing. Even with such index, we can only get -r {DATE} to
work but handling the date range {DATE1}:{DATE2} requires massive
changes in the underlying logic and potentially APIs. The reason is
that the date range potentially translates into a sequence of revision
ranges which brakes assumptions of path continuity in e.g. 'svn log'.

-- Stefan^2.
Received on 2014-02-05 06:08:35 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.