[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Invalid Makefile.PL generated if --enable-sqlite-compatibility-version specified

From: James McCoy <jamessan_at_debian.org>
Date: Thu, 16 Jan 2014 23:23:26 -0500

When --enable-sqlite-compatibility-version is used, the configure script
ends up defining CFLAGS such that it contains

    -DSVN_SQLITE_MIN_VERSION='"X.Y.Z"'

This string then makes it into the generated
subversion/bindings/swig/perl/native/Makefile.PL as

    my $cflags = '… -DSVN_SQLITE_MIN_VERSION='"X.Y.Z"' …';

which causes the perl script to have invalid syntax:

    cd ./subversion/bindings/swig/perl/native; \
                    /usr/bin/perl Makefile.PL INSTALLDIRS=vendor; \
                    sed -i -e '/^LD_RUN_PATH/s/^/#/' Makefile Makefile.[a-z]*
    String found where operator expected at Makefile.PL line 55, near "'-DSVN_SQLITE_MIN_VERSION_NUMBER=3007012 -DSVN_SQLITE_MIN_VERSION='"3.7.12""
            (Missing operator before "3.7.12"?)
    String found where operator expected at Makefile.PL line 55, near ""3.7.12"' -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -pthread'"
            (Missing operator before ' -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -pthread'?)
    syntax error at Makefile.PL line 55, near "'-DSVN_SQLITE_MIN_VERSION_NUMBER=3007012 -DSVN_SQLITE_MIN_VERSION='"3.7.12""
    Execution of Makefile.PL aborted due to compilation errors.

The attached patch fixes the issue for me.

Cheers,

-- 
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <jamessan_at_debian.org>

Received on 2014-01-17 05:24:04 CET

This is an archived mail posted to the Subversion Dev mailing list.