[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1544736 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 25 Nov 2013 12:05:52 +0000 (GMT)

Branko Čibej wrote:
>> Author: stefan2
>> URL: http://svn.apache.org/r1544736
>> * subversion/libsvn_ra_svn/marshal.c
>>   (svn_ra_svn__handle_command): code cleanup. No functional change
>
> Your change modifies the *terminate output parameter even if the
> function fails. We have a long-standing policy against doing that.
> You're taking too much for granted.

We have a general policy, as I understand it, that if a function returns an error then we don't promise anything about what else it has done. On that basis, this change is fine. Is there some local policy overriding that general one in this case?

- Julian
Received on 2013-11-25 13:06:29 CET

This is an archived mail posted to the Subversion Dev mailing list.