[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1544736 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Sun, 24 Nov 2013 09:46:15 +0100

On 23.11.2013 03:09, stefan2_at_apache.org wrote:
> Author: stefan2
> Date: Sat Nov 23 02:08:59 2013
> New Revision: 1544736
>
> URL: http://svn.apache.org/r1544736
> Log:
> * subversion/libsvn_ra_svn/marshal.c
> (svn_ra_svn__handle_command): code cleanup. No functional change

Your change modifies the *terminate output parameter even if the
function fails. We have a long-standing policy against doing that.
You're taking too much for granted.

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane_at_wandisco.com
Received on 2013-11-24 09:46:59 CET

This is an archived mail posted to the Subversion Dev mailing list.