[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnserve - don't ignore errors

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 25 Nov 2013 11:46:54 +0000 (GMT)

Stefan Fuhrmann wrote:

> On Thu, Nov 21, 2013 at 8:18 PM, Julian Foad wrote:
>> In r1544253 I added error checking to some socket initiliazation cases.
>> I haven't reproduced such errors, I just followed the obvious coding
>> pattern to add the missing checks.
>> I would appreciate a review of that to ensure it wasn't ignoring errors
>> on purpose in either of those places.
> As far as I can tell, this should be fine. Svnserve has been somewhat
> neglected in the past, so things like error handling and logging were not
> particularly consistent. 1.9 is an improvement in this department.
> I think we should simply document these changes in the release notes
> (just added a basic template for 1.9).

>> In r1544256 I added error checking to the main exit code path of both
>> inetd and tunnel modes. This one is easily demonstrated [...]
> Same here. I love how the new sub_main() function makes all sorts
> of cleanup and error reporting much simpler.

Thanks, on both counts.

I have now mentioned these in the 'CHANGES' file.

- Julian
Received on 2013-11-25 12:47:39 CET

This is an archived mail posted to the Subversion Dev mailing list.