[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Make constructors of some JavaHL classes public

From: Dmitry Pavlenko <pavlenko_at_tmatesoft.com>
Date: Wed, 4 Sep 2013 16:17:25 +0200

I thought about that, but there's a lot of such comments even above public constructors (e.g. above
Lock class constructor). I think, this comment will still be true even the after change because
within Subversion project the class will still be constructed only from JNI code.

> 2013/9/4 Dmitry Pavlenko <pavlenko_at_tmatesoft.com>:
> > Hello all!
> > There're 2 classes in JavaHL interface (CommitItem and ConflictVersion)
> > that have package local constructors that makes it difficult to
> > construct them from SVNKit. I would ask you to make the constructors
> > public.
> >
> > [[[
> > Make constructors of CommitItem and ConflictVersion publc.
> >
> > *
> > subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.j
> > ava
> >
> > (CommitItem): Make constructor public.
> >
> > *
> > subversion/bindings/javahl/src/org/apache/subversion/javahl/types/Confli
> > ctVersion.java
> >
> > (ConflictVersion): Make constructor public.
> >
> > ]]]
> > [[[
> > Index:
> > subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.j
> > ava ===================================================================
> > ---
> > subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.j
> > ava (revision 1519992) +++
> > subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.j
> > ava (working copy) @@ -84,7 +84,7 @@ public class CommitItem implements
> > java.io.Seriali
> >
> > * @param r revision number
> > * @param mf move source abspath
> > */
> >
> > - CommitItem(String p, NodeKind nk, int sf, String u, String cu, long
> > r, String mf) + public CommitItem(String p, NodeKind nk, int sf,
> > String u, String cu, long r, String mf)
> >
> > {
> >
> > path = p;
> > nodeKind = nk;
> >
> > Index:
> > subversion/bindings/javahl/src/org/apache/subversion/javahl/types/Confli
> > ctVersion.java
> > =================================================================== ---
> > subversion/bindings/javahl/src/org/apache/subversion/javahl/types/Confli
> > ctVersion.java (revision 1519992)
> > +++
> > subversion/bindings/javahl/src/org/apache/subversion/javahl/types/Confli
> > ctVersion.java (working copy)
> > @@ -38,7 +38,7 @@ public class ConflictVersion
> >
> > private NodeKind nodeKind;
> >
> > /** This constructor should only be called from JNI code. */
>
> If you are going to call this constructor, then I think the above
> comment should be changed as well.
>
> > - ConflictVersion(String reposURL, String reposUUID,
> > + public ConflictVersion(String reposURL, String reposUUID,
> >
> > long pegRevision, String pathInRepos,
> > NodeKind nodeKind)
> >
> > {
> >
> > ]]]
>
> Best regards,
> Konstantin Kolinko
Received on 2013-09-04 16:18:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.