[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Make constructors of some JavaHL classes public

From: Konstantin Kolinko <knst.kolinko_at_gmail.com>
Date: Wed, 4 Sep 2013 17:37:01 +0400

2013/9/4 Dmitry Pavlenko <pavlenko_at_tmatesoft.com>:
> Hello all!
> There're 2 classes in JavaHL interface (CommitItem and ConflictVersion) that have package local
> constructors that makes it difficult to construct them from SVNKit. I would ask you to make the
> constructors public.
>
> [[[
> Make constructors of CommitItem and ConflictVersion publc.
>
> * subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java
> (CommitItem): Make constructor public.
>
> * subversion/bindings/javahl/src/org/apache/subversion/javahl/types/ConflictVersion.java
> (ConflictVersion): Make constructor public.
>
> ]]]
> [[[
> Index: subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java
> ===================================================================
> --- subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java (revision 1519992)
> +++ subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java (working copy)
> @@ -84,7 +84,7 @@ public class CommitItem implements java.io.Seriali
> * @param r revision number
> * @param mf move source abspath
> */
> - CommitItem(String p, NodeKind nk, int sf, String u, String cu, long r, String mf)
> + public CommitItem(String p, NodeKind nk, int sf, String u, String cu, long r, String mf)
> {
> path = p;
> nodeKind = nk;
> Index: subversion/bindings/javahl/src/org/apache/subversion/javahl/types/ConflictVersion.java
> ===================================================================
> --- subversion/bindings/javahl/src/org/apache/subversion/javahl/types/ConflictVersion.java
> (revision 1519992)
> +++ subversion/bindings/javahl/src/org/apache/subversion/javahl/types/ConflictVersion.java
> (working copy)
> @@ -38,7 +38,7 @@ public class ConflictVersion
> private NodeKind nodeKind;
>
> /** This constructor should only be called from JNI code. */

If you are going to call this constructor, then I think the above
comment should be changed as well.

> - ConflictVersion(String reposURL, String reposUUID,
> + public ConflictVersion(String reposURL, String reposUUID,
> long pegRevision, String pathInRepos,
> NodeKind nodeKind)
> {
> ]]]

Best regards,
Konstantin Kolinko
Received on 2013-09-04 15:37:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.