Re: [PATCH] Make constructors of some JavaHL classes public

On 04.09.2013 15:50, Mark Phippard wrote:
> On Wed, Sep 4, 2013 at 9:47 AM, Branko Čibej <brane_at_wandisco.com
> <mailto:brane_at_wandisco.com>> wrote:
>
> On 04.09.2013 15:03, Dmitry Pavlenko wrote:
> > Hello all!
> > There're 2 classes in JavaHL interface (CommitItem and
> ConflictVersion) that have package local
> > constructors that makes it difficult to construct them from
> SVNKit. I would ask you to make the
> > constructors public.
>
> I disagree. Those constructors are not meant to be used by the JavaHL
> API consumers. If SVNKit wants to instantiate those classes for some
> reason, it'll have to do some package injection magic.
>
> Although I have trouble understanding why SVNKit would want to use
> JavaHL ...
>
>
> Besides providing its own Java API for working with Subversion, SVNKit
> also provides an implementation of the JavaHL interfaces. This allows
> applications like Subclipse, which are written to the JavaHL
> interfaces, to swap in SVNKit or the native libraries as the
> implementation at runtime.

I know that. I still don't know why that would require making those
constructors public.

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane_at_wandisco.com