Hello all!
There're 2 classes in JavaHL interface (CommitItem and ConflictVersion) that have package local
constructors that makes it difficult to construct them from SVNKit. I would ask you to make the
constructors public.
[[[
Make constructors of CommitItem and ConflictVersion publc.
* subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java
(CommitItem): Make constructor public.
* subversion/bindings/javahl/src/org/apache/subversion/javahl/types/ConflictVersion.java
(ConflictVersion): Make constructor public.
]]]
[[[
Index: subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java
===================================================================
--- subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java (revision 1519992)
+++ subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java (working copy)
@@ -84,7 +84,7 @@ public class CommitItem implements java.io.Seriali
* @param r revision number
* @param mf move source abspath
*/
- CommitItem(String p, NodeKind nk, int sf, String u, String cu, long r, String mf)
+ public CommitItem(String p, NodeKind nk, int sf, String u, String cu, long r, String mf)
{
path = p;
nodeKind = nk;
Index: subversion/bindings/javahl/src/org/apache/subversion/javahl/types/ConflictVersion.java
===================================================================
--- subversion/bindings/javahl/src/org/apache/subversion/javahl/types/ConflictVersion.java
(revision 1519992)
+++ subversion/bindings/javahl/src/org/apache/subversion/javahl/types/ConflictVersion.java
(working copy)
@@ -38,7 +38,7 @@ public class ConflictVersion
private NodeKind nodeKind;
/** This constructor should only be called from JNI code. */
- ConflictVersion(String reposURL, String reposUUID,
+ public ConflictVersion(String reposURL, String reposUUID,
long pegRevision, String pathInRepos,
NodeKind nodeKind)
{
]]]
Received on 2013-09-04 15:05:15 CEST