[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add 'svn:use-commit-times' property

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 22 Aug 2013 15:31:33 +0100

masaru tsuchiyama <m.tmatma_at_gmail.com> writes:

> + if (!fb->adding_file)
> + {
> + if (fb->use_commit_times && fb->changed_date)
> + {
> + SVN_ERR(svn_io_set_file_affected_time(fb->changed_date,
> + fb->local_abspath,
> + scratch_pool));
> + }
> + else if (fb->remove_use_commit_times)
> + {
> + SVN_ERR(svn_io_set_file_affected_time(apr_time_now(),
> + fb->local_abspath,
> + scratch_pool));
> + }
> + }
> +

The call to apr_time_now still looks wrong to me. If I understand the
patch it causes the timestamp to be updated to the current time when
svn:use-commit-times is removed. I don't know how this feature is
supposed to be used but I would expect the timestamp to be unchanged
when the property is removed. Is setting it to the current time
useful behaviour?

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2013-08-22 16:32:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.